corrcected msitakes

backend/src/utils/landmarks_manager.py

@@ -8,7 +8,7 @@ from ..structs.preferences import Preferences
 from ..structs.landmark import Landmark
 from .take_most_important import take_most_important
 from .cluster_manager import ClusterManager
-from ..overpass.overpass import Overpass
+from ..overpass.overpass import Overpass, get_base_info
 
 from ..constants import AMENITY_SELECTORS_PATH, LANDMARK_PARAMETERS_PATH, OPTIMIZER_PARAMETERS_PATH, OSM_CACHE_DIR
 
@@ -239,28 +239,19 @@ class LandmarkManager:
         landmarks = []
         for osm_type in ['node', 'way', 'relation'] :
             for elem in root.findall(osm_type):
-                name = elem.find("tag[@k='name']").get('v') if elem.find("tag[@k='name']") is not None else None
-                tags = elem.findall('tag')
 
-                if osm_type != 'node' :
-                    center = elem.find('center')
-                    lat = float(center.get('lat'))
-                    lon = float(center.get('lon'))
-                    coords = tuple((lat, lon))
-
-                else :
-                    lat = float(elem.get('lat'))
-                    lon = float(elem.get('lon'))
-                    coords = tuple((lat, lon))
+                id, coords, name = get_base_info(elem, osm_type, with_name=True)
 
                 if name is None or coords is None :
                     continue
 
+                tags = elem.findall('tag')
+
                 # Convert this to Landmark object
                 landmark = Landmark(name=name,
                                     type=landmarktype,
                                     location=coords,
-                                    osm_id=elem.get('id'),
+                                    osm_id=id,
                                     osm_type=osm_type,
                                     attractiveness=0,
                                     n_tags=len(tags))