cleanup

backend/src/tests/test_cache.py

@@ -1,42 +0,0 @@
-"""Collection of tests to ensure correct handling of invalid input."""
-
-from fastapi.testclient import TestClient
-import pytest
-
-from .test_utils import load_trip_landmarks
-from ..main import app
-
-
-@pytest.fixture(scope="module")
-def client():
-    """Client used to call the app."""
-    return TestClient(app)
-
-
-def test_cache(client):    # pylint: disable=redefined-outer-name
-    """
-    Test n°1 : Custom test in Turckheim to ensure small villages are also supported.
-
-    Args:
-        client:
-        request:
-    """
-    duration_minutes = 15
-    response = client.post(
-        "/trip/new",
-        json={
-            "preferences": {"sightseeing": {"type": "sightseeing", "score": 5},
-            "nature": {"type": "nature", "score": 5},
-            "shopping": {"type": "shopping", "score": 5},
-            "max_time_minute": duration_minutes,
-            "detour_tolerance_minute": 0},
-            "start": [48.084588, 7.280405]
-            }
-        )
-    result = response.json()
-    landmarks = load_trip_landmarks(client, result['first_landmark_uuid'])
-    landmarks_cached = load_trip_landmarks(client, result['first_landmark_uuid'], True)
-
-    # checks :
-    assert response.status_code == 200  # check for successful planning
-    assert landmarks_cached == landmarks

backend/src/tests/test_main.py

@@ -11,7 +11,7 @@ def client():
     """Client used to call the app."""
     return TestClient(app)
 
-'''
+
 def test_turckheim(client, request):    # pylint: disable=redefined-outer-name
     """
     Test n°1 : Custom test in Turckheim to ensure small villages are also supported.
@@ -54,8 +54,8 @@ def test_turckheim(client, request):    # pylint: disable=redefined-outer-name
     assert len(landmarks) > 2           # check that there is something to visit
     assert comp_time < 30, f"Computation time exceeded 30 seconds: {comp_time:.2f} seconds"
     # assert 2==3
-'''
 
+'''
 def test_bellecour(client, request) :   # pylint: disable=redefined-outer-name
     """
     Test n°2 : Custom test in Lyon centre to ensure proper decision making in crowded area.
@@ -97,7 +97,7 @@ def test_bellecour(client, request) :   # pylint: disable=redefined-outer-name
     assert duration_minutes*0.8 < int(result['total_time']) < duration_minutes*1.2
     # assert 2 == 3
 
-'''
+
 def test_cologne(client, request) :   # pylint: disable=redefined-outer-name
     """
     Test n°2 : Custom test in Lyon centre to ensure proper decision making in crowded area.
@@ -216,7 +216,7 @@ def test_zurich(client, request) :   # pylint: disable=redefined-outer-name
     assert response.status_code == 200  # check for successful planning
     assert comp_time < 30, f"Computation time exceeded 30 seconds: {comp_time:.2f} seconds"
     assert duration_minutes*0.8 < int(result['total_time']) < duration_minutes*1.2
-'''
+
 
 def test_paris(client, request) :   # pylint: disable=redefined-outer-name
     """
@@ -257,7 +257,7 @@ def test_paris(client, request) :   # pylint: disable=redefined-outer-name
     assert comp_time < 30, f"Computation time exceeded 30 seconds: {comp_time:.2f} seconds"
     assert duration_minutes*0.8 < int(result['total_time']) < duration_minutes*1.2
 
-'''
+
 def test_new_york(client, request) :   # pylint: disable=redefined-outer-name
     """
     Test n°2 : Custom test in New York (les Halles) centre to ensure proper decision making in crowded area.

backend/src/tests/test_utils.py

@@ -23,44 +23,7 @@ def landmarks_to_osmid(landmarks: list[Landmark]) -> list[int] :
 
     return ids
 
-def fetch_landmark(client, landmark_uuid: str):
-    """
-    Fetch landmark data from the API based on the landmark UUID.
-
-    Args:
-        landmark_uuid (str): The UUID of the landmark.
-
-    Returns:
-        dict: Landmark data fetched from the API.
-    """
-    logger = logging.getLogger(__name__)
-    response = client.get(f'/landmark/{landmark_uuid}')
-
-    if response.status_code != 200:
-        raise HTTPException(status_code=500,
-                            detail=f'Failed to fetch landmark with UUID {landmark_uuid}: {response.status_code}')
-
-    try:
-        json_data = response.json()
-        # logger.info(f'API Response: {json_data}')
-    except ValueError as e:
-        logger.error(f'Failed to parse response as JSON: {response.text}')
-        raise HTTPException(status_code=500, detail="Invalid response format from API") from e
-
-    # Try validating against the Landmark model here to ensure consistency
-    try:
-        landmark = Landmark(**json_data)
-    except ValidationError as ve:
-        logging.error(f'Validation error: {ve}')
-        raise HTTPException(status_code=500, detail="Invalid data format received from API") from ve
-
-    if "detail" in json_data:
-        raise HTTPException(status_code=500, detail=json_data["detail"])
-
-    return landmark
-
-
-def fetch_landmark_cache(landmark_uuid: str):
+def fetch_landmark(landmark_uuid: str):
     """
     Fetch landmark data from the cache based on the landmark UUID.
 
@@ -91,7 +54,7 @@ def fetch_landmark_cache(landmark_uuid: str):
         raise HTTPException(status_code=500, detail="An unexpected error occurred while fetching the landmark from the cache") from exc
 
 
-def load_trip_landmarks(client, first_uuid: str, from_cache=None) -> list[Landmark]:
+def load_trip_landmarks(client, first_uuid: str) -> list[Landmark]:
     """
     Load all landmarks for a trip using the response from the API.
 
@@ -105,10 +68,7 @@ def load_trip_landmarks(client, first_uuid: str, from_cache=None) -> list[Landma
     next_uuid = first_uuid
 
     while next_uuid is not None:
-        if from_cache :
-            landmark = fetch_landmark_cache(next_uuid)
-        else :
-            landmark = fetch_landmark(client, next_uuid)
+        landmark = fetch_landmark(next_uuid)
 
         landmarks.append(landmark)
         next_uuid = landmark.next_uuid  # Prepare for the next iteration