linting

backend/src/overpass/overpass.py

@@ -59,7 +59,7 @@ class Overpass :
             return Overpass._filter_landmarks(cached_responses, bbox)
 
         # If there is no cached data, fetch all from Overpass.
-        elif not cached_responses :
+        if not cached_responses :
             query_str = Overpass.build_query(bbox, osm_types, selector, conditions, out)
             self.logger.debug(f'Query string: {query_str}')
             return self.fetch_data_from_api(query_str)
@@ -114,7 +114,7 @@ class Overpass :
             with urllib.request.urlopen(request) as response:
 
                 # Convert the HTTPResponse to a string and load data
-                response_data = response.read().decode('utf-8')  
+                response_data = response.read().decode('utf-8')
                 data = json.loads(response_data)
 
                 # Get elements and set cache
@@ -309,9 +309,9 @@ class Overpass :
         if min_lat == float('inf') or min_lon == float('inf'):
             return None
 
-        return (max(min_lat, original_bbox[0]), 
-                max(min_lon, original_bbox[1]), 
-                min(max_lat, original_bbox[2]), 
+        return (max(min_lat, original_bbox[0]),
+                max(min_lon, original_bbox[1]),
+                min(max_lat, original_bbox[2]),
                 min(max_lon, original_bbox[3]))
 
 
@@ -405,7 +405,7 @@ def fill_cache():
 
                 try :
                     # Read the whole file content as a string
-                    with open(entry.path, 'r') as f:
+                    with open(entry.path, 'r', encoding='utf-8') as f:
                         # load data and fill the cache with the query and key
                         json_data = json.load(f)
                         overpass.fill_cache(json_data)
@@ -413,4 +413,4 @@ def fill_cache():
                     os.remove(entry.path)
 
                 except Exception as exc :
-                    overpass.logger.error(f'An error occured while parsing file {entry.path} as .json file')
+                    overpass.logger.error(f'An error occured while parsing file {entry.path} as .json file: {str(exc)}')